Adding the `.rom` suffix to emitted events

Issues
1

Hey there!

Would it be possible to add the .rom suffix to the events emitted through the instrumentation plugin? It’s how ActiveRecord works with ActiveSupport::Notifications and it’ll make things easier to identify different sql emitted events.

If it’s possible I’m happy to open a PR with the changes: Rename emitted events to "sql.rom" · luismiramirez/rom-sql@6aa64c5 · GitHub

Thanks!

1 Like
2

If you could make it configurable, then a PR would be great. It should default to :sql for backward-compatibility reasons.

3

Sure! I’ll work on it. Thank you!

4

Something that just came to my mind that I want to ask.

Since the next rom-sql release is going to be a major version bump, wouldn’t it be reasonable if the events are emitted with the suffix by default?