How can I improve this query?

elithecho · April 18, 2022, 11:37am

I have a small repo for trying out ROM and using multi_insert. I think it could be improved but am wondering how can I do this without a separate query?

github.com

elithecho/rom-test/blob/main/lib/app/repos/user_repo.rb#L21-L39

      
        
            def create_with_tasks(user)
              users.transaction do
                task_attrs = user[:tasks]
                user = users.changeset(:create, user).map(:add_timestamps).commit
            
            
    # It does not set the timestamps
                # https://www.rubydoc.info/github/rom-rb/rom-sql/ROM/SQL/Relation
                # https://www.rubydoc.info/github/rom-rb/rom-sql/ROM/SQL/Relation#multi_insert-instance_method
                new_tasks = tasks.multi_insert(task_attrs.map do |task|
                  task.merge!(
                    user_id: user.id,
                    created_at: Time.now,
                    updated_at: Time.now
                  )
                end)
              end
            
            
  get_by_id(user.id).combine(:tasks).one
            end

Topic		Replies	Views
Rom-sql upsert multiple entities by default Usage Stories	8	2677	June 28, 2018
Issue: Combine relation with different foreign keys Issues	0	820	December 5, 2017
How do you set timestamps in version 4.0? Site Feedback	7	2215	April 2, 2018
How to combine multiple UPDATE statements? Issues	1	427	April 4, 2022
Multi insert only inserts columns present in the first tuple Issues	3	1111	June 26, 2019

How can I improve this query?

Related topics